Skip to content

Argo types + QN support + package bumps #5159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 5, 2024
Merged

Argo types + QN support + package bumps #5159

merged 7 commits into from
Jun 5, 2024

Conversation

@kdembler
Copy link
Collaborator

@kdembler kdembler commented Jun 3, 2024 •
edited
Loading

Based on #5158

  • Updated @joystream/types package with new chain metadata
  • Bumped versions of all packages depending on types
  • Added QN support for new proposal type

dobertRowneySr
dobertRowneySr approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@dobertRowneySr dobertRowneySr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kdembler kdembler marked this pull request as draft June 4, 2024 13:08
@kdembler kdembler marked this pull request as ready for review June 5, 2024 07:59
freakstatic
freakstatic approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@freakstatic freakstatic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the typo on PalletArgoBridgeBridgeConstraints the rest seems good
never mind :)
LGTM!

@dobertRowneySr dobertRowneySr self-requested a review June 5, 2024 10:03
@kdembler kdembler merged commit 7d5493c into Joystream:petra Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@freakstatic freakstatic freakstatic approved these changes

@dobertRowneySr dobertRowneySr dobertRowneySr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kdembler @freakstatic @dobertRowneySr